tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py ('k') | tools/telemetry/telemetry/web_perf/timeline_interaction_record.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py b/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py

index 2f6c85ac9045dced71701c033dec413b7b9bc873..983ff0bd8b883620720dacbfd776a8a345cc0c5b 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py

@@ -60,6 +60,7 @@ class SmoothnessMetricUnitTest(unittest.TestCase):

def testComputeLatencyMetric(self):

stats = _MockRenderingStats(frame_timestamps=self.good_timestamps,

input_event_latency=[[10, 20], [30, 40, 50]])

+ # pylint: disable=unbalanced-tuple-unpacking

mean_value, discrepancy_value = self.metric._ComputeLatencyMetric(

self.page, stats, 'input_event_latency', stats.input_event_latency)

self.assertEquals(30, mean_value.value)

@@ -76,6 +77,7 @@ class SmoothnessMetricUnitTest(unittest.TestCase):

stats = _MockRenderingStats(

frame_timestamps=self.not_enough_frames_timestamps,

input_event_latency=[[], []])

+ # pylint: disable=unbalanced-tuple-unpacking

mean_value, discrepancy_value = self.metric._ComputeLatencyMetric(

self.page, stats, 'input_event_latency', stats.input_event_latency)

self.assertEquals(None, mean_value.value)