tools/telemetry/telemetry/timeline/thread.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/timeline/thread.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/timeline/thread.py

diff --git a/tools/telemetry/telemetry/timeline/thread.py b/tools/telemetry/telemetry/timeline/thread.py

index ce8151e0c283e6a575d90d88e8672c0faf02f6fb..1c4a6da9e32f2fa4fbbdec55c0b23a5795f8a579 100644

--- a/tools/telemetry/telemetry/timeline/thread.py

+++ b/tools/telemetry/telemetry/timeline/thread.py

@@ -250,7 +250,7 @@ class Thread(event_container.TimelineEventContainer):

# two end=start+duration combos that should be the same will be slightly

# different. Round back to micros to ensure equality below.

child_end_micros = round(child.end * 1000)

- root_end_micros = round(root.end * 1000)

+ root_end_micros = round(root.end * 1000)

if child.start >= root.start and child_end_micros <= root_end_micros:

if len(root.sub_slices) > 0:

if self._AddSliceIfBounds(root.sub_slices[-1], child):

« no previous file with comments | « tools/telemetry/telemetry/timeline/model.py ('k') | tools/telemetry/telemetry/timeline/trace_event_importer.py » ('j') | no next file with comments »