tools/telemetry/telemetry/timeline/counter.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/timeline/counter.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/timeline/empty_timeline_data_importer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/timeline/counter.py

diff --git a/tools/telemetry/telemetry/timeline/counter.py b/tools/telemetry/telemetry/timeline/counter.py

index 2e62508e81d19e667999cfa4322c4bc385b93e2c..07698b10b54fb56f7d4338931fe0f4c07e5c760e 100644

--- a/tools/telemetry/telemetry/timeline/counter.py

+++ b/tools/telemetry/telemetry/timeline/counter.py

@@ -52,7 +52,7 @@ class Counter(event_container.TimelineEventContainer):

def __init__(self, parent, category, name):

super(Counter, self).__init__(name, parent)

self.category = category

- self.full_name = category + '.' + name

+ self.full_name = category + '.' + name

self.samples = []

self.timestamps = []

self.series_names = []

@@ -71,7 +71,7 @@ class Counter(event_container.TimelineEventContainer):

# creating a ton of garbage for rejected samples.

test_sample = CounterSample(self, 0)

for i in xrange(len(self.timestamps)):

- test_sample._sample_index = i

+ test_sample._sample_index = i # pylint: disable=protected-access

if event_predicate(test_sample):

yield CounterSample(self, i)