tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/test_expectations_unittest.py ('k') | tools/telemetry/telemetry/results/csv_pivot_table_output_formatter_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py

diff --git a/tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py b/tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py

index 02da431eaa8331ba77c96dfc3ec0c324acfda31a..eb3a1223efe878198d0911beec35fc092ffe9b27 100644

--- a/tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py

+++ b/tools/telemetry/telemetry/results/csv_pivot_table_output_formatter.py

@@ -35,7 +35,7 @@ class CsvPivotTableOutputFormatter(output_formatter.OutputFormatter):

# Observe trace_tag. Use comma to split up the trace tag.

tag_values = self._trace_tag.split(',')

- tag_values = filter(lambda x: x, tag_values) # filter empty list entries

+ tag_values = [x for x in tag_values if x] # filter empty list entries

tag_headers = ['trace_tag_%d' % i for i in range(len(tag_values))]

# Write header.