tools/telemetry/telemetry/page/shared_page_state.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr_unittest.py ('k') | tools/telemetry/telemetry/page/test_expectations_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 913914e01c3130e94da1f45eae2a7c7ff41e5c44..5d64701509dc1d21aa67eefd97db743b30109bbb 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -7,6 +7,7 @@ import sys

from telemetry import decorators

from telemetry.core import browser_finder

+from telemetry.core import browser_finder_exceptions

from telemetry.core import browser_info

from telemetry.core import util

from telemetry.core import wpr_modes

@@ -32,7 +33,7 @@ class SharedPageState(object):

''' Return a possible_browser with the given options. '''

possible_browser = browser_finder.FindBrowser(finder_options)

if not possible_browser:

- raise browser_finder.BrowserFinderException(

+ raise browser_finder_exceptions.BrowserFinderException(

'No browser found.\n\nAvailable browsers:\n%s\n' %

'\n'.join(browser_finder.GetAllAvailableBrowserTypes(finder_options)))

finder_options.browser_options.browser_type = (