tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/monsoon_profiler.py ('k') | tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

index 014fd8397ed4960894afb7fc8c5b5fa9b4881509..05dc5035c71f12625f31641b5289af0d1e77bc79 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py

@@ -36,16 +36,16 @@ class TestPerfProfiler(unittest.TestCase):

try:

self.assertEqual(

perf_profiler.PerfProfiler.GetTopSamples(profile_file, 10),

- { 'v8::internal::StaticMarkingVisitor::MarkMapContents': 63615201,

- 'v8::internal::RelocIterator::next': 38271931,

- 'v8::internal::LAllocator::MeetConstraintsBetween': 42913933,

- 'v8::internal::FlexibleBodyVisitor::Visit': 31909537,

- 'v8::internal::LiveRange::CreateAssignedOperand': 42913933,

- 'void v8::internal::RelocInfo::Visit': 96878864,

- 'WebCore::HTMLTokenizer::nextToken': 48240439,

- 'v8::internal::Scanner::ScanIdentifierOrKeyword': 46054550,

- 'sk_memset32_SSE2': 45121317,

- 'v8::internal::HeapObject::Size': 39786862

- })

+ {'v8::internal::StaticMarkingVisitor::MarkMapContents': 63615201,

+ 'v8::internal::RelocIterator::next': 38271931,

+ 'v8::internal::LAllocator::MeetConstraintsBetween': 42913933,

+ 'v8::internal::FlexibleBodyVisitor::Visit': 31909537,

+ 'v8::internal::LiveRange::CreateAssignedOperand': 42913933,

+ 'void v8::internal::RelocInfo::Visit': 96878864,

+ 'WebCore::HTMLTokenizer::nextToken': 48240439,

+ 'v8::internal::Scanner::ScanIdentifierOrKeyword': 46054550,

+ 'sk_memset32_SSE2': 45121317,

+ 'v8::internal::HeapObject::Size': 39786862

+ })

finally:

perf_profiler.subprocess = real_subprocess