tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py ('k') | tools/telemetry/telemetry/core/platform/profiler/monsoon.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

index 95794c511661c8337c411bf1a1cd896976bd4612..981e903f0fee72dee862d5fc9e953121a0b784bf 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

@@ -49,6 +49,7 @@ class AndroidTraceviewProfiler(profiler.Profiler):

output_files = []

for pid, trace_file in self._trace_files:

self._browser_backend.adb.RunShellCommand('am profile %s stop' % pid)

+ # pylint: disable=cell-var-from-loop

util.WaitFor(lambda: self._FileSize(trace_file) > 0, timeout=10)

output_files.append(trace_file)

self._browser_backend.adb.device().old_interface.Adb().Pull(