tools/telemetry/telemetry/core/platform/posix_platform_backend.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/posix_platform_backend.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/monsoon_power_monitor_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/posix_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/posix_platform_backend.py b/tools/telemetry/telemetry/core/platform/posix_platform_backend.py

index c9ebc6dfa40f9e76a2a2dc189a949e00b2636fdd..6816f07a7910f57768203af5495020767205640b 100644

--- a/tools/telemetry/telemetry/core/platform/posix_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/posix_platform_backend.py

@@ -56,7 +56,7 @@ class PosixPlatformBackend(desktop_platform_backend.DesktopPlatformBackend):

"""Returns a list of child pids of |pid|."""

ps_output = self.GetPsOutput(['pid', 'ppid', 'state'])

ps_line_re = re.compile(

- '\s*(?P<pid>\d+)\s*(?P<ppid>\d+)\s*(?P<state>\S*)\s*')

+ r'\s*(?P<pid>\d+)\s*(?P<ppid>\d+)\s*(?P<state>\S*)\s*')

processes = []

for pid_ppid_state in ps_output:

m = ps_line_re.match(pid_ppid_state)

@@ -74,7 +74,7 @@ class PosixPlatformBackend(desktop_platform_backend.DesktopPlatformBackend):

def IsApplicationRunning(self, application):

ps_output = self.GetPsOutput(['command'])

application_re = re.compile(

- '(.*%s|^)%s(\s|$)' % (os.path.sep, application))

+ r'(.*%s|^)%s(\s|$)' % (os.path.sep, application))

return any(application_re.match(cmd) for cmd in ps_output)

def LaunchApplication(