tools/telemetry/telemetry/core/bitmap.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/bitmap.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/webdriver/webdriver_ie_backend.py ('k') | tools/telemetry/telemetry/core/browser_credentials.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/bitmap.py

diff --git a/tools/telemetry/telemetry/core/bitmap.py b/tools/telemetry/telemetry/core/bitmap.py

index f130cc4317207bd7f968c084c6a40b7be59edfeb..ead38b1c97c7b0dbc8996b0c2fd051a0f1ab0057 100644

--- a/tools/telemetry/telemetry/core/bitmap.py

+++ b/tools/telemetry/telemetry/core/bitmap.py

@@ -111,8 +111,8 @@ class RgbaColor(collections.namedtuple('RgbaColor', ['r', 'g', 'b', 'a'])):

assert self.IsEqual(RgbaColor(r, g, b, a), tolerance)

-WEB_PAGE_TEST_ORANGE = RgbaColor(222, 100, 13)

-WHITE = RgbaColor(255, 255, 255)

+WEB_PAGE_TEST_ORANGE = RgbaColor(222, 100, 13)

+WHITE = RgbaColor(255, 255, 255)

class _BitmapTools(object):

@@ -220,6 +220,7 @@ class Bitmap(object):

"""Flat pixel array of the bitmap."""

if self._crop_box:

self._pixels = self._PrepareTools().CropPixels()

+ # pylint: disable=unpacking-non-sequence

_, _, self._width, self._height = self._crop_box

self._crop_box = None

if type(self._pixels) is not bytearray: