tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 9ae22fa1618177dc02184077f42e1a4a9f2a7f90..9bdd2432f57fd692556f04bb7042bed4ebdb72b9 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -263,11 +263,11 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

resp = json.loads(data)

if 'Protocol-Version' in resp:

if 'Browser' in resp:

- branch_number_match = re.search('Chrome/\d+\.\d+\.(\d+)\.\d+',

+ branch_number_match = re.search(r'Chrome/\d+\.\d+\.(\d+)\.\d+',

resp['Browser'])

else:

branch_number_match = re.search(

- 'Chrome/\d+\.\d+\.(\d+)\.\d+ (Mobile )?Safari',

+ r'Chrome/\d+\.\d+\.(\d+)\.\d+ (Mobile )?Safari',

resp['User-Agent'])

if branch_number_match: