Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 739613003: Remove dead code in ContentVideoView. (Closed)

Created:
6 years, 1 month ago by Ignacio Solla
Modified:
6 years, 1 month ago
Reviewers:
Ted C, qinmin
CC:
chromium-reviews, darin-cc_chromium.org, jam, avayvod+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dead code in ContentVideoView. This code was used when Android native controls were used for fullscreen video instead of html5 controls. Committed: https://crrev.com/e72da7ae104759fcb9d50527aef095dd58ab213e Cr-Commit-Position: refs/heads/master@{#305028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -150 lines) Patch
M content/browser/android/content_video_view.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/android/content_video_view.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 11 chunks +9 lines, -73 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ignacio Solla
qinmin@chromium.org: Please review browser_media_player_manager tedchoc@chromium.org: Please review ContentVideoView
6 years, 1 month ago (2014-11-19 03:48:11 UTC) #2
qinmin
lgtm
6 years, 1 month ago (2014-11-19 06:24:29 UTC) #3
Ted C
lgtm
6 years, 1 month ago (2014-11-19 19:05:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739613003/1
6 years, 1 month ago (2014-11-20 16:41:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 17:34:39 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:35:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e72da7ae104759fcb9d50527aef095dd58ab213e
Cr-Commit-Position: refs/heads/master@{#305028}

Powered by Google App Engine
This is Rietveld 408576698