src/runtime/runtime-debug.cc - Issue 739523002: Allow stepping into Object.observe handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 739523002: Allow stepping into Object.observe handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 68d2f9e4777d0ef30b9e558345ef37039eca26cc..0a72439858009d0cf7193677cdefa75713bf8406 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -2732,7 +2732,8 @@ RUNTIME_FUNCTION(Runtime_GetScript) {

// to a built-in function such as Array.forEach.

RUNTIME_FUNCTION(Runtime_DebugCallbackSupportsStepping) {

DCHECK(args.length() == 1);

- if (!isolate->debug()->is_active() || !isolate->debug()->StepInActive()) {

+ Debug* debug = isolate->debug();

+ if (!debug->is_active() || debug->LastStepAction() != StepIn) {

return isolate->heap()->false_value();

}

CONVERT_ARG_CHECKED(Object, callback, 0);