Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 739513003: Accelerator Key's in the Omnibox's context menu are not visible. (Closed)

Created:
6 years, 1 month ago by Deepak
Modified:
6 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Accelerator Key's in the Omnibox's context menu are not visible. Accelerator key's are not visible, so user have to open the context menu to do operation. Changes done to show Accelerator key's in Context menu. BUG=434339 Committed: https://crrev.com/1632212303e465db54ae8f996d1b69d3d559b9ef Cr-Commit-Position: refs/heads/master@{#304775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M ui/views/controls/textfield/textfield.cc View 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Deepak
PTAL.
6 years, 1 month ago (2014-11-18 13:48:50 UTC) #2
msw
lgtm
6 years, 1 month ago (2014-11-18 19:11:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739513003/1
6 years, 1 month ago (2014-11-19 01:07:30 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 1 month ago (2014-11-19 07:10:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739513003/1
6 years, 1 month ago (2014-11-19 07:11:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 07:33:41 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 07:34:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1632212303e465db54ae8f996d1b69d3d559b9ef
Cr-Commit-Position: refs/heads/master@{#304775}

Powered by Google App Engine
This is Rietveld 408576698