Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: Source/core/editing/MarkupAccumulator.cpp

Issue 739433003: Remove CDATASection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/MarkupAccumulator.h ('k') | Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/MarkupAccumulator.cpp
diff --git a/Source/core/editing/MarkupAccumulator.cpp b/Source/core/editing/MarkupAccumulator.cpp
index 018521e5947e24c00360b14aa4a20d7b78a07042..b76f9caa745bc1099e932d0dcb8a8ae594424cea 100644
--- a/Source/core/editing/MarkupAccumulator.cpp
+++ b/Source/core/editing/MarkupAccumulator.cpp
@@ -31,12 +31,12 @@
#include "core/XLinkNames.h"
#include "core/XMLNSNames.h"
#include "core/XMLNames.h"
-#include "core/dom/CDATASection.h"
#include "core/dom/Comment.h"
#include "core/dom/Document.h"
#include "core/dom/DocumentFragment.h"
#include "core/dom/DocumentType.h"
#include "core/dom/ProcessingInstruction.h"
+#include "core/dom/Text.h"
#include "core/editing/Editor.h"
#include "core/html/HTMLElement.h"
#include "core/html/HTMLTemplateElement.h"
@@ -471,14 +471,6 @@ void MarkupAccumulator::appendAttribute(StringBuilder& result, const Element& el
}
}
-void MarkupAccumulator::appendCDATASection(StringBuilder& result, const String& section)
-{
- // FIXME: CDATA content is not escaped, but XMLSerializer (and possibly other callers) should raise an exception if it includes "]]>".
- result.appendLiteral("<![CDATA[");
- result.append(section);
- result.appendLiteral("]]>");
-}
-
void MarkupAccumulator::appendStartMarkup(StringBuilder& result, Node& node, Namespaces* namespaces)
{
switch (node.nodeType()) {
@@ -502,9 +494,6 @@ void MarkupAccumulator::appendStartMarkup(StringBuilder& result, Node& node, Nam
case Node::ELEMENT_NODE:
appendElement(result, toElement(node), namespaces);
break;
- case Node::CDATA_SECTION_NODE:
- appendCDATASection(result, toCDATASection(node).data());
- break;
case Node::ATTRIBUTE_NODE:
ASSERT_NOT_REACHED();
break;
« no previous file with comments | « Source/core/editing/MarkupAccumulator.h ('k') | Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698