Issue 739413004: Wire up Sky directly to Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 739413004: Wire up Sky directly to Ganesh (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
rafaelw, ojan

CC:
ojan, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Wire up Sky directly to Ganesh This CL wires up Sky directly to Ganesh via the Sky compositor. Currently this code is compiled out of the binary because it's a bit buggy, but this CL is a start. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd7ed376a080563c28d0091419353b0f3f8f1cb6

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -7 lines)			Patch
M	sky/viewer/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/document_view.h	View	1	5 chunks	+25 lines, -4 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	1	5 chunks	+49 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

6 years, 1 month ago (2014-11-21 03:15:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
dd7ed376a080563c28d0091419353b0f3f8f1cb6 (presubmit successful).