Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 739413004: Wire up Sky directly to Ganesh (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
rafaelw, ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Wire up Sky directly to Ganesh This CL wires up Sky directly to Ganesh via the Sky compositor. Currently this code is compiled out of the binary because it's a bit buggy, but this CL is a start. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd7ed376a080563c28d0091419353b0f3f8f1cb6

Patch Set 1 #

Patch Set 2 : rebaes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -7 lines) Patch
M sky/viewer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 5 chunks +25 lines, -4 lines 0 comments Download
M sky/viewer/document_view.cc View 1 5 chunks +49 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-20 21:51:49 UTC) #2
ojan
lgtm
6 years, 1 month ago (2014-11-20 23:55:39 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-21 03:15:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dd7ed376a080563c28d0091419353b0f3f8f1cb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698