Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 739383002: Don't drop messages/events send to a service worker that is stopping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@termnate_sw
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 3eb9bda1c5f1c2a44dbc1b5f56ed481b50080b41..d3bbeb753379dda04a6eab646b60987b0bc1984f 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -291,12 +291,13 @@ void EmbeddedWorkerInstance::OnStopped() {
NotifyWorkerDestroyed(process_id_, worker_devtools_agent_route_id_);
if (context_)
context_->process_manager()->ReleaseWorkerProcess(embedded_worker_id_);
+ Status old_status = status_;
status_ = STOPPED;
process_id_ = -1;
thread_id_ = -1;
worker_devtools_agent_route_id_ = MSG_ROUTING_NONE;
start_callback_.Reset();
- FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped());
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped(old_status));
}
void EmbeddedWorkerInstance::OnPausedAfterDownload() {

Powered by Google App Engine
This is Rietveld 408576698