Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739323002: Requests for tabs permission for VirtualKeyboard. (Closed)

Created:
6 years, 1 month ago by rsadam
Modified:
5 years, 4 months ago
Reviewers:
Shu Chen, kevers
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Requests for tabs permission for VirtualKeyboard. The URL of the current tab page is needed, and this permission grants it. BUG= Committed: https://crrev.com/2498435f59b9108cb0e485dbd77d3bc39f796a65 Cr-Commit-Position: refs/heads/master@{#305042}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -22 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_interface.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/input_ime.json View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/extensions/input_ime/main.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/chromeos/ime_bridge.h View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/text_input_client.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/controls/prefix_selector.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/prefix_selector.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1282823002 Patch 1

Messages

Total messages: 10 (3 generated)
rsadam
Hi Shu, PTAL!
6 years, 1 month ago (2014-11-19 21:17:42 UTC) #2
Shu Chen
lgtm
6 years, 1 month ago (2014-11-20 00:36:20 UTC) #3
rsadam
+kevers for ui/keyboard OWNERS
6 years, 1 month ago (2014-11-20 17:36:51 UTC) #5
kevers
lgtm
6 years, 1 month ago (2014-11-20 17:39:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739323002/20001
6 years, 1 month ago (2014-11-20 17:51:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 18:36:34 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:37:13 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2498435f59b9108cb0e485dbd77d3bc39f796a65
Cr-Commit-Position: refs/heads/master@{#305042}

Powered by Google App Engine
This is Rietveld 408576698