Issue 739303005: add clip to PictureRenderer to better mimic Chromium's rendering method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 739303005: add clip to PictureRenderer to better mimic Chromium's rendering method (Closed)

Created:
6 years ago by robertphillips

Modified:
6 years ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

add clip to PictureRenderer to better mimic Chromium's rendering method Since Chromium uses separate canvases when rendering tiles they get an implicit clip. This adds an explicit clip since the PictureRenderer reuses the same canvas. Committed: https://skia.googlesource.com/skia/+/43044ddd111d1e53607221a93d0774ce8a62acf0

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/PictureRenderer.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739303005/1

6 years ago (2014-11-28 15:32:32 UTC) #5

commit-bot: I haz the power

6 years ago (2014-11-28 15:42:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/43044ddd111d1e53607221a93d0774ce8a62acf0

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages