Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 739263003: Add a media scanner convenience class. (Closed)

Created:
6 years, 1 month ago by Ben Kwa
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a media scanner convenience class. Create a new class that takes in a list of directories, recursively scans them for image and video files, and returns the resulting list. This is a re-do of 730353002, which fixes a flakey test. BUG=420680 TEST=browser_test: FileManagerJsTest.MediaScannerTest Committed: https://crrev.com/24c3d02f6f904b623869fee4a20c688dc1695af5 Cr-Commit-Position: refs/heads/master@{#304971}

Patch Set 1 #

Patch Set 2 : Fix flakey media_scanner_unittest. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -3 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/test/data/file_manager/unit_tests/media_scanner_unittest.html View 1 chunk +8 lines, -3 lines 0 comments Download
A chrome/test/data/file_manager/unit_tests/media_scanner_unittest.js View 1 1 chunk +263 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/background/js/media_scanner.js View 1 chunk +65 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ben Kwa
6 years, 1 month ago (2014-11-20 01:57:46 UTC) #2
fukino
On 2014/11/20 01:57:46, Ben Kwa wrote: lgtm
6 years, 1 month ago (2014-11-20 02:01:27 UTC) #3
fukino
On 2014/11/20 01:57:46, Ben Kwa wrote: lgtm
6 years, 1 month ago (2014-11-20 02:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739263003/40001
6 years, 1 month ago (2014-11-20 02:06:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 04:27:03 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 04:27:50 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/24c3d02f6f904b623869fee4a20c688dc1695af5
Cr-Commit-Position: refs/heads/master@{#304971}

Powered by Google App Engine
This is Rietveld 408576698