Issue 739263002: Remove debug-only fData from SKTDArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 739263002: Remove debug-only fData from SKTDArray. (Closed)

Created:
6 years, 1 month ago by mtklein_C

Modified:
6 years, 1 month ago

Reviewers:
Tom Hudson, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove debug-only fData from SKTDArray. It makes the code harder to read, and makes Debug and Release SkTDArrays different sizes. Looks like fData is left over from when debuggers weren't very good at inspecting data structures. No API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/48b411af76fac533c05852d856e8e7e33df4965f

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -30 lines)			Patch
	M	include/core/SkTDArray.h	View		8 chunks	+0 lines, -30 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739263002/1

6 years, 1 month ago (2014-11-19 17:28:45 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-19 17:41:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/48b411af76fac533c05852d856e8e7e33df4965f