Shared Raster Worker Threads

cc/resources/picture_pile.cc

Index: cc/resources/picture_pile.cc
diff --git a/cc/resources/picture_pile.cc b/cc/resources/picture_pile.cc
old mode 100644
new mode 100755
index 68d75d7aea14e29e21c65a16e6ae7eac90f17b29..951133713795d7e3aec54ccb36bf006f61a5d0f6
--- a/cc/resources/picture_pile.cc
+++ b/cc/resources/picture_pile.cc
@@ -9,6 +9,7 @@
 #include <vector>
 
 #include "cc/base/region.h"
+#include "cc/base/switches.h"
 #include "cc/debug/rendering_stats_instrumentation.h"
 #include "cc/resources/picture_pile_impl.h"
 #include "cc/resources/tile_priority.h"
@@ -231,10 +232,11 @@ bool PicturePile::Update(
       }
       int recorded_pixel_count =
           picture->LayerRect().width() * picture->LayerRect().height();
+      size_t num_raster_threads = switches::GetNumRasterThreads();
       stats_instrumentation->AddRecord(best_duration, recorded_pixel_count);
-      if (num_raster_threads_ > 1)
+      if (num_raster_threads > 1)
         picture->GatherPixelRefs(tile_grid_info_);
-      picture->CloneForDrawing(num_raster_threads_);
+      picture->CloneForDrawing(static_cast<int>(num_raster_threads));

[vmpstr, 2013/12/30 21:13:01]

Might as well switch CloneForDrawing to take size_t instead, there's no good
reason it's an int

[sohanjg, 2013/12/31 06:31:25]

If we make CloneForDrawing() take size_t param, then again we need to do a cast
while calling, SkPicture::clone(SkPicture* pictures, int count). Not sure what
would be the best thing, make CloneForDrawing() take size_t and cast while
calling clone(), or cast here, and keep the rest of the code as is.

[reveman, 2014/01/02 03:50:08]

Maybe switches::GetNumRasterThreads() should return an int instead.

[vmpstr, 2014/01/02 05:29:16]

My thought was just if we can do this with no cast, it would be better.
Returning an int would work, I think. I mean, SkPicture::clone signature is the
limiting factor here

     }
 
     for (TilingData::Iterator it(&tiling_, record_rect);