Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: cc/resources/worker_pool.h

Issue 73923003: Shared Raster Worker Threads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase for Commit Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/worker_pool.h
diff --git a/cc/resources/worker_pool.h b/cc/resources/worker_pool.h
old mode 100644
new mode 100755
index b4d2623842d0a70482ff56373b39be9785249ddf..86184e8a14ec05d4a01cc6ca9e74b5d2ecfb1831
--- a/cc/resources/worker_pool.h
+++ b/cc/resources/worker_pool.h
@@ -105,7 +105,13 @@ class CC_EXPORT WorkerPool {
// completed.
virtual void Shutdown();
- protected:
+ // Force a check for completed tasks.
+ virtual void CheckForCompletedWorkerTasks();
reveman 2014/01/16 08:00:44 This function is not virtual anymore and it's alre
sohanjg 2014/01/16 08:56:49 Done.
+
+ // Gets the number of threads to use for running raster tasks.
+ // TODO(reveman): Move this to RasterWorkerPool: crbug.com/331844
+ static int GetNumRasterThreads();
+
// A task graph contains a unique set of tasks with edges between
// dependencies pointing in the direction of the dependents. Each task
// need to be assigned a unique priority and a run count that matches
@@ -113,8 +119,10 @@ class CC_EXPORT WorkerPool {
typedef base::ScopedPtrHashMap<internal::WorkerPoolTask*, internal::GraphNode>
GraphNodeMap;
typedef GraphNodeMap TaskGraph;
+ typedef std::vector<scoped_refptr<internal::WorkerPoolTask> > TaskVector;
- WorkerPool(size_t num_threads, const std::string& thread_name_prefix);
+ protected:
+ WorkerPool();
// Schedule running of tasks in |graph|. Any previously scheduled tasks
// that are not already running will be canceled. Canceled tasks don't run
@@ -125,17 +133,9 @@ class CC_EXPORT WorkerPool {
void CheckForCompletedWorkerTasks();
private:
- class Inner;
- friend class Inner;
-
- typedef std::vector<scoped_refptr<internal::WorkerPoolTask> > TaskVector;
-
void ProcessCompletedTasks(const TaskVector& completed_tasks);
bool in_dispatch_completion_callbacks_;
-
- // Hide the gory details of the worker pool in |inner_|.
- const scoped_ptr<Inner> inner_;
};
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698