Shared Raster Worker Threads

cc/resources/raster_worker_pool.cc

Index: cc/resources/raster_worker_pool.cc
diff --git a/cc/resources/raster_worker_pool.cc b/cc/resources/raster_worker_pool.cc
old mode 100644
new mode 100755
index 06fd18e62e0ec2bdc9d440ee0ae6eb925c867ef4..1388d541be14555da141ea525f01c9ae9733546d
--- a/cc/resources/raster_worker_pool.cc
+++ b/cc/resources/raster_worker_pool.cc
@@ -319,7 +319,8 @@ class RasterFinishedWorkerPoolTaskImpl : public internal::WorkerPoolTask {
   DISALLOW_COPY_AND_ASSIGN(RasterFinishedWorkerPoolTaskImpl);
 };
 
-const char* kWorkerThreadNamePrefix = "CompositorRaster";
+const int kDefaultNumRasterThreads = 1;

[reveman, 2014/01/06 20:01:35]

nit: I'd add a blank line after this

[sohanjg, 2014/01/07 08:35:23]

Done.

+static int num_raster_threads = kDefaultNumRasterThreads;

[reveman, 2014/01/06 20:01:35]

s/num_raster_threads/g_num_raster_threads/

if you initialize this to 0 then you can DCHECK that it's not set twice.

nit: 'static' is not really necessary here.

[sohanjg, 2014/01/07 08:35:23]

Done.

 
 }  // namespace
 
@@ -461,10 +462,25 @@ RasterWorkerPool::Task RasterWorkerPool::CreateImageDecodeTask(
                                                 reply));
 }
 
-RasterWorkerPool::RasterWorkerPool(ResourceProvider* resource_provider,
-                                   size_t num_threads)
-    : WorkerPool(num_threads, kWorkerThreadNamePrefix),
-      client_(NULL),
+// static
+void RasterWorkerPool::SetNumRasterThreads(int num_threads) {
+  DCHECK(num_threads);

[reveman, 2014/01/06 20:01:35]

I prefer DCHECK_LT(0, num_threads)

also add DCHECK_EQ(0, g_num_raster_threads)

[sohanjg, 2014/01/07 08:35:23]

Done.

+
+  num_raster_threads = num_threads;
+}
+
+// static
+int RasterWorkerPool::GetNumRasterThreads() {

[reveman, 2014/01/06 20:01:35]

Let's just use WorkerPool::GetNumRasterThreads() for now until I clean this up
in a follow up.

[sohanjg, 2014/01/07 08:35:23]

Done.

+  return num_raster_threads;
+}
+
+// static
+int WorkerPool::GetNumRasterThreads() {

[reveman, 2014/01/06 20:01:35]

if you make this:

{
  if (!g_num_raster_threads)
    g_num_raster_threads = kDefaultNumRasterThreads;

  return g_num_raster_threads;
}

DCHECK will also fail if someone decides to call SetNumRasterThreads after
GetNumRasterThreads has been called.

[sohanjg, 2014/01/07 08:35:23]

Done.

+  return RasterWorkerPool::GetNumRasterThreads();
+}
+
+RasterWorkerPool::RasterWorkerPool(ResourceProvider* resource_provider)
+    : client_(NULL),
       resource_provider_(resource_provider),
       weak_ptr_factory_(this) {
 }