Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 739123002: Move DisplayPowerServiceProvider to chromeos/dbus/services (Closed)

Created:
6 years, 1 month ago by hashimoto
Modified:
6 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, hashimoto+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move DisplayPowerServiceProvider to chromeos/dbus/services Introduce DisplayPowerServiceProvider::Delegate to get rid of dependencies to ash/ and ui/. BUG=429354 Committed: https://crrev.com/c73d4a8360141fc2a8a0674a7210c5375cfca457 Cr-Commit-Position: refs/heads/master@{#304984}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -172 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.h View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc View 1 chunk +37 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/dbus/display_power_service_provider.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/chromeos/dbus/display_power_service_provider.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + chromeos/dbus/services/display_power_service_provider.h View 4 chunks +21 lines, -6 lines 0 comments Download
A + chromeos/dbus/services/display_power_service_provider.cc View 3 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hashimoto
6 years, 1 month ago (2014-11-19 08:58:21 UTC) #2
Daniel Erat
lgtm. this is probably another case where we should probably have a non-chrome-specific delegate, or ...
6 years, 1 month ago (2014-11-19 15:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739123002/1
6 years, 1 month ago (2014-11-20 03:17:53 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/chrome_browser_main_chromeos.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-11-20 04:05:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739123002/20001
6 years, 1 month ago (2014-11-20 04:49:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 05:59:00 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 05:59:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c73d4a8360141fc2a8a0674a7210c5375cfca457
Cr-Commit-Position: refs/heads/master@{#304984}

Powered by Google App Engine
This is Rietveld 408576698