Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 739073002: Upstream DeviceClassManager (Closed)

Created:
6 years, 1 month ago by Jaekyun Seok (inactive)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Upstream DeviceClassManager The downstream cleanup CL is https://chrome-internal-review.googlesource.com/#/c/184696/ . BUG=428823 Committed: https://crrev.com/f79171d90c0a39c6749b1463908f88211e30516f Cr-Commit-Position: refs/heads/master@{#304940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/device/DeviceClassManager.java View 1 chunk +166 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jaekyun Seok (inactive)
Please review this CL to upstream DeviceClassManager. Thanks,
6 years, 1 month ago (2014-11-19 04:46:04 UTC) #2
David Trainor- moved to gerrit
lgtm
6 years, 1 month ago (2014-11-19 17:41:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739073002/1
6 years, 1 month ago (2014-11-19 23:37:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 00:22:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:23:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f79171d90c0a39c6749b1463908f88211e30516f
Cr-Commit-Position: refs/heads/master@{#304940}

Powered by Google App Engine
This is Rietveld 408576698