Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739063002: Fix accessibility of remaining html form controls on Android (Closed)

Created:
6 years, 1 month ago by dmazzoni
Modified:
6 years, 1 month ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_tablet_popup
Project:
chromium
Visibility:
Public.

Description

Fix accessibility of remaining input types on Android This fixes the accessibility of the html select element and html input elements with a type of date, time, and color. BUG=378799 Committed: https://crrev.com/080f90fecf246aa762d480148202fa3bedd345a0 Cr-Commit-Position: refs/heads/master@{#305145}

Patch Set 1 #

Patch Set 2 : Better #

Total comments: 2

Patch Set 3 : Update expectations, remove log spam #

Patch Set 4 : Rebase, un-disable tests #

Patch Set 5 : Update Mac expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -36 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 6 chunks +43 lines, -10 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M content/test/data/accessibility/input-color-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-date.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-date-expected-android.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/input-date-expected-mac.txt View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/input-range-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-time.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-time-expected-android.txt View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/input-time-expected-mac.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/input-types-expected-android.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/select-expected-android.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dmazzoni
6 years, 1 month ago (2014-11-19 07:24:58 UTC) #2
Peter Lundblad
lgtm https://codereview.chromium.org/739063002/diff/20001/content/renderer/accessibility/renderer_accessibility.cc File content/renderer/accessibility/renderer_accessibility.cc (right): https://codereview.chromium.org/739063002/diff/20001/content/renderer/accessibility/renderer_accessibility.cc#newcode256 content/renderer/accessibility/renderer_accessibility.cc:256: LOG(ERROR) << "AX event: " << ui::ToString(event.event_type) Log ...
6 years, 1 month ago (2014-11-19 10:46:01 UTC) #3
dmazzoni
https://codereview.chromium.org/739063002/diff/20001/content/renderer/accessibility/renderer_accessibility.cc File content/renderer/accessibility/renderer_accessibility.cc (right): https://codereview.chromium.org/739063002/diff/20001/content/renderer/accessibility/renderer_accessibility.cc#newcode256 content/renderer/accessibility/renderer_accessibility.cc:256: LOG(ERROR) << "AX event: " << ui::ToString(event.event_type) On 2014/11/19 ...
6 years, 1 month ago (2014-11-19 19:06:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739063002/80001
6 years, 1 month ago (2014-11-21 00:31:31 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-21 01:57:37 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 01:58:16 UTC) #8
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/080f90fecf246aa762d480148202fa3bedd345a0
Cr-Commit-Position: refs/heads/master@{#305145}

Powered by Google App Engine
This is Rietveld 408576698