Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Unified Diff: base/android/java/src/org/chromium/base/ContentUriUtils.java

Issue 739033003: Support content scheme uri for Chrome on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/content_uri_utils_unittest.cc ('k') | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/ContentUriUtils.java
diff --git a/base/android/java/src/org/chromium/base/ContentUriUtils.java b/base/android/java/src/org/chromium/base/ContentUriUtils.java
index 70c27ed14167f8dc36774878e0f3b8df2058132c..ef527e1cfaeb3f035aa6cdabdd48d4ce81b0a8d6 100644
--- a/base/android/java/src/org/chromium/base/ContentUriUtils.java
+++ b/base/android/java/src/org/chromium/base/ContentUriUtils.java
@@ -12,6 +12,7 @@ import android.os.ParcelFileDescriptor;
import android.util.Log;
import java.io.File;
+import java.io.FileNotFoundException;
/**
* This class provides methods to access content URI schemes.
@@ -26,11 +27,11 @@ public abstract class ContentUriUtils {
*/
public interface FileProviderUtil {
/**
- * Generate a content uri from the given file.
+ * Generate a content URI from the given file.
* @param context Application context.
* @param file The file to be translated.
*/
- public Uri getContentUriFromFile(Context context, File file);
+ Uri getContentUriFromFile(Context context, File file);
}
// Prevent instantiation.
@@ -54,7 +55,7 @@ public abstract class ContentUriUtils {
*
* @param context {@link Context} in interest
* @param uriString the content URI to open
- * @returns file desciptor upon sucess, or -1 otherwise.
+ * @return file desciptor upon sucess, or -1 otherwise.
*/
@CalledByNative
public static int openContentUriForRead(Context context, String uriString) {
@@ -70,23 +71,34 @@ public abstract class ContentUriUtils {
*
* @param context {@link Context} in interest.
* @param uriString the content URI to query.
- * @returns true if the uri exists, or false otherwise.
+ * @return true if the URI exists, or false otherwise.
*/
@CalledByNative
public static boolean contentUriExists(Context context, String uriString) {
- ParcelFileDescriptor pfd = getParcelFileDescriptor(context, uriString);
- if (pfd == null) {
- return false;
- }
- return true;
+ return getParcelFileDescriptor(context, uriString) != null;
+ }
+
+ /**
+ * Retrieve the MIME type for the content URI.
+ *
+ * @param context {@link Context} in interest.
+ * @param uriString the content URI to look up.
+ * @return MIME type or null if the input params are empty or invalid.
+ */
+ @CalledByNative
+ public static String getMimeType(Context context, String uriString) {
+ ContentResolver resolver = context.getContentResolver();
+ if (resolver == null) return null;
+ Uri uri = Uri.parse(uriString);
+ return resolver.getType(uri);
}
/**
- * Helper method to open a content URI and return the ParcelFileDescriptor.
+ * Helper method to open a content URI and returns the ParcelFileDescriptor.
*
* @param context {@link Context} in interest.
* @param uriString the content URI to open.
- * @returns ParcelFileDescriptor of the content URI, or NULL if the file does not exist.
+ * @return ParcelFileDescriptor of the content URI, or NULL if the file does not exist.
*/
private static ParcelFileDescriptor getParcelFileDescriptor(Context context, String uriString) {
ContentResolver resolver = context.getContentResolver();
@@ -95,8 +107,12 @@ public abstract class ContentUriUtils {
ParcelFileDescriptor pfd = null;
try {
pfd = resolver.openFileDescriptor(uri, "r");
- } catch (java.io.FileNotFoundException e) {
+ } catch (FileNotFoundException e) {
Log.w(TAG, "Cannot find content uri: " + uriString, e);
+ } catch (SecurityException e) {
+ Log.w(TAG, "Cannot open content uri: " + uriString, e);
+ } catch (IllegalArgumentException e) {
+ Log.w(TAG, "Unknown content uri: " + uriString, e);
}
return pfd;
}
@@ -107,7 +123,7 @@ public abstract class ContentUriUtils {
* @param uri the content URI to be resolved.
* @param contentResolver the content resolver to query.
* @param columnField the column field to query.
- * @returns the display name of the @code uri if present in the database
+ * @return the display name of the @code uri if present in the database
* or an empty string otherwise.
*/
public static String getDisplayName(
« no previous file with comments | « base/android/content_uri_utils_unittest.cc ('k') | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698