Support content scheme uri for Chrome on Android

base/android/java/src/org/chromium/base/ContentUriUtils.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.base;
 
 import android.content.ContentResolver;
 import android.content.Context;
 import android.database.Cursor;
 import android.net.Uri;
 import android.os.ParcelFileDescriptor;
 import android.util.Log;
 
 import java.io.File;
 
 /**
  * This class provides methods to access content URI schemes.
  */
 public abstract class ContentUriUtils {
     private static final String TAG = "ContentUriUtils";
     private static FileProviderUtil sFileProviderUtil;
 
     /**
      * Provides functionality to translate a file into a content URI for use
      * with a content provider.
      */
     public interface FileProviderUtil {
         /**
-         * Generate a content uri from the given file.
+         * Generate a content URI from the given file.
          * @param context Application context.
          * @param file The file to be translated.
          */
         public Uri getContentUriFromFile(Context context, File file);

[nyquist, 2014/11/20 20:01:11]

This is implicitly public.

[qinmin, 2014/11/20 23:07:19]

ok, removed the public keyword.

     }
 
     // Prevent instantiation.
     private ContentUriUtils() {}
 
     public static void setFileProviderUtil(FileProviderUtil util) {
         sFileProviderUtil = util;
     }
 
     public static Uri getContentUriFromFile(Context context, File file) {
@@ skipping 19 matching lines @@
             return pfd.detachFd();
         }
         return -1;
     }
 
     /**
      * Check whether a content URI exists.
      *
      * @param context {@link Context} in interest.
      * @param uriString the content URI to query.
-     * @returns true if the uri exists, or false otherwise.
+     * @returns true if the URI exists, or false otherwise.
      */
     @CalledByNative
     public static boolean contentUriExists(Context context, String uriString) {
         ParcelFileDescriptor pfd = getParcelFileDescriptor(context, uriString);
         if (pfd == null) {

[nyquist, 2014/11/20 20:01:11]

Optional: This bugs me; feel free to change this to return pfd != null. You
could at that point also inline pfd.

[qinmin, 2014/11/20 23:07:19]

Done.

             return false;
         }
         return true;
     }
 
     /**
+     * Retrieve the MIME type for the content URI.
+     *
+     * @param context {@link Context} in interest.
+     * @param uriString the content URI to look up.
+     * @returns MIME type or null if the input params are empty or invalid.

[nyquist, 2014/11/20 20:01:11]

This should be @return (throughout this file)

[qinmin, 2014/11/20 23:07:18]

Done.

+     */
+    @CalledByNative
+    public static String getMimeType(Context context, String uriString) {
+        ContentResolver resolver = context.getContentResolver();
+        Uri uri = Uri.parse(uriString);
+        if (resolver == null || uri == null) return null;

[nyquist, 2014/11/20 20:01:11]

Uri.parse(...) never returns null (specifically mentioned in the API).

[qinmin, 2014/11/20 23:07:19]

Done.

+        return resolver.getType(uri);
+    }
+
+    /**
      * Helper method to open a content URI and return the ParcelFileDescriptor.
      *
      * @param context {@link Context} in interest.
      * @param uriString the content URI to open.
      * @returns ParcelFileDescriptor of the content URI, or NULL if the file does not exist.
      */
     private static ParcelFileDescriptor getParcelFileDescriptor(Context context, String uriString) {
         ContentResolver resolver = context.getContentResolver();
         Uri uri = Uri.parse(uriString);
 
         ParcelFileDescriptor pfd = null;
         try {
             pfd = resolver.openFileDescriptor(uri, "r");
         } catch (java.io.FileNotFoundException e) {

[nyquist, 2014/11/20 20:01:11]

could you change this one to import FileNotFoundException as well?

[qinmin, 2014/11/20 23:07:18]

Done.

             Log.w(TAG, "Cannot find content uri: " + uriString, e);
+        } catch (SecurityException e) {
+            Log.w(TAG, "Cannot open content uri: " + uriString, e);
         }
         return pfd;
     }
 
     /**
      * Method to resolve the display name of a content URI.
      *
      * @param uri the content URI to be resolved.
      * @param contentResolver the content resolver to query.
      * @param columnField the column field to query.
@@ skipping 15 matching lines @@
         } catch (NullPointerException e) {
             // Some android models don't handle the provider call correctly.
             // see crbug.com/345393
             return "";
         } finally {
             if (cursor != null) cursor.close();
         }
         return "";
     }
 }