Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 73903002: Merged r17772 into 3.22 branch. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Merged r17772 into 3.22 branch. Fix missing type feedback check for Generic*String addition. BUG=318671 R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=17779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M src/hydrogen.cc View 2 chunks +19 lines, -9 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-318671.js View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 1 month ago (2013-11-15 10:34:45 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-11-15 10:35:35 UTC) #2
Benedikt Meurer
7 years, 1 month ago (2013-11-15 10:35:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698