Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2953)

Unified Diff: content/renderer/input/input_handler_proxy.cc

Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_handler_proxy.cc
diff --git a/content/renderer/input/input_handler_proxy.cc b/content/renderer/input/input_handler_proxy.cc
index 21f3359f90736ba35e32a8f552cf8add554352d3..1009bd8e0afedd3bb6f9b8b3fec441d78ace73e5 100644
--- a/content/renderer/input/input_handler_proxy.cc
+++ b/content/renderer/input/input_handler_proxy.cc
@@ -293,9 +293,9 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleMouseWheel(
// TODO(jamesr): We don't properly handle scroll by page in the compositor
// thread, so punt it to the main thread. http://crbug.com/236639
result = DID_NOT_HANDLE;
- } else if (wheel_event.modifiers & WebInputEvent::ControlKey) {
- // Wheel events involving the control key never trigger scrolling, only
- // event handlers. Forward to the main thread.
+ } else if (!wheel_event.canScroll) {
+ // Wheel events involving the control key with canScroll false will not
tdresser 2014/12/02 15:37:38 I don't think you need to reference both the contr
lanwei 2014/12/02 22:28:06 Done.
+ // trigger scrolling, only event handlers. Forward to the main thread.
result = DID_NOT_HANDLE;
} else if (smooth_scroll_enabled_) {
cc::InputHandler::ScrollStatus scroll_status =

Powered by Google App Engine
This is Rietveld 408576698