Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: content/renderer/input/input_handler_proxy.cc

Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/input_handler_proxy.cc
diff --git a/content/renderer/input/input_handler_proxy.cc b/content/renderer/input/input_handler_proxy.cc
index 21f3359f90736ba35e32a8f552cf8add554352d3..ae843e07fe0e68dd61fb0341bc12c263f8329868 100644
--- a/content/renderer/input/input_handler_proxy.cc
+++ b/content/renderer/input/input_handler_proxy.cc
@@ -293,7 +293,7 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleMouseWheel(
// TODO(jamesr): We don't properly handle scroll by page in the compositor
// thread, so punt it to the main thread. http://crbug.com/236639
result = DID_NOT_HANDLE;
- } else if (wheel_event.modifiers & WebInputEvent::ControlKey) {
+ } else if (wheel_event.suppressScroll) {
// Wheel events involving the control key never trigger scrolling, only
Rick Byers 2014/11/27 17:31:32 Update this comment since it's no longer true - co
lanwei 2014/12/02 06:28:54 Done.
// event handlers. Forward to the main thread.
result = DID_NOT_HANDLE;

Powered by Google App Engine
This is Rietveld 408576698