Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: content/browser/renderer_host/web_input_event_aura.cc

Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unittests Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/web_input_event_aura.cc
diff --git a/content/browser/renderer_host/web_input_event_aura.cc b/content/browser/renderer_host/web_input_event_aura.cc
index c4a766a8d1e3191c298ce3e329fbb64892bbec20..28b893f5e1f6e8e1ddf1f15d8fbfa1b5162a3d24 100644
--- a/content/browser/renderer_host/web_input_event_aura.cc
+++ b/content/browser/renderer_host/web_input_event_aura.cc
@@ -193,6 +193,14 @@ blink::WebMouseWheelEvent MakeWebMouseWheelEvent(
webkit_event.globalX = root_point.x();
webkit_event.globalY = root_point.y();
+ // Scroll events generated from the mouse wheel when the control key is held
+ // don't trigger scrolling. Instead, they may cause zooming.
+ bool from_mouse_wheel = !webkit_event.hasPreciseScrollingDeltas;
+ if ((webkit_event.modifiers & blink::WebInputEvent::ControlKey) &&
+ from_mouse_wheel) {
+ webkit_event.canScroll = false;
+ }
+
return webkit_event;
}

Powered by Google App Engine
This is Rietveld 408576698