content/renderer/input/input_handler_proxy_unittest.cc - Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/input/input_handler_proxy_unittest.cc

Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit tests Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/input/web_input_event_traits_unittest.cc ('K') | « content/renderer/input/input_handler_proxy.cc ('k') | content/shell/renderer/test_runner/event_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/input/input_handler_proxy_unittest.cc

diff --git a/content/renderer/input/input_handler_proxy_unittest.cc b/content/renderer/input/input_handler_proxy_unittest.cc

index aafe9187371cceb5f7ce7f84c8fe6ede3342792c..0eea520a97b205aa88ed407d2f8a76750e2fb8e5 100644

--- a/content/renderer/input/input_handler_proxy_unittest.cc

+++ b/content/renderer/input/input_handler_proxy_unittest.cc

@@ -288,12 +288,12 @@ TEST_F(InputHandlerProxyTest, MouseWheelByPageMainThread) {

testing::Mock::VerifyAndClearExpectations(&mock_client_);

}

-TEST_F(InputHandlerProxyTest, MouseWheelWithCtrl) {

+TEST_F(InputHandlerProxyTest, MouseWheelWithCtrlNotScroll) {

expected_disposition_ = InputHandlerProxy::DID_NOT_HANDLE;

WebMouseWheelEvent wheel;

wheel.type = WebInputEvent::MouseWheel;

wheel.modifiers = WebInputEvent::ControlKey;

+ wheel.canScroll = false;

EXPECT_EQ(expected_disposition_, input_handler_->HandleInputEvent(wheel));

testing::Mock::VerifyAndClearExpectations(&mock_client_);

}