content/browser/renderer_host/input/input_router_impl.cc - Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/input/input_router_impl.cc

diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc

index 4848f6dc6f41075434b458e3baa78175298962aa..23713cc566288d9b5c0ef621f1880b1a479c2864 100644

--- a/content/browser/renderer_host/input/input_router_impl.cc

+++ b/content/browser/renderer_host/input/input_router_impl.cc

@@ -457,7 +457,8 @@ void InputRouterImpl::SendSyntheticWheelEventForPinch(

wheelEvent.wheelTicksX = 0;

wheelEvent.wheelTicksY =

pinch_event.event.data.pinchUpdate.scale > 1 ? 1 : -1;

+ // Prevent trackpad pinch from scrolling on Mac OS.

+ wheelEvent.canScroll = false;

SendWheelEvent(QueuedWheelEvent(

MouseWheelEventWithLatencyInfo(wheelEvent, pinch_event.latency), true));

}

« no previous file with comments | « no previous file | content/browser/renderer_host/web_input_event_aura.cc » ('j') | content/browser/renderer_host/web_input_event_aura.cc » ('J')