Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: content/common/input/web_input_event_traits.cc

Issue 739013008: Explicitly suppress scrolling for wheel events that will trigger zooming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify event_sender.cc Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/input/web_input_event_traits.h" 5 #include "content/common/input/web_input_event_traits.h"
6 6
7 #include <bitset> 7 #include <bitset>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 event.globalY, 51 event.globalY,
52 event.movementX, 52 event.movementX,
53 event.movementY, 53 event.movementY,
54 event.clickCount); 54 event.clickCount);
55 } 55 }
56 56
57 void ApppendEventDetails(const WebMouseWheelEvent& event, std::string* result) { 57 void ApppendEventDetails(const WebMouseWheelEvent& event, std::string* result) {
58 StringAppendF(result, 58 StringAppendF(result,
59 "{\n Delta: (%f, %f)\n WheelTicks: (%f, %f)\n Accel: (%f, %f)\n" 59 "{\n Delta: (%f, %f)\n WheelTicks: (%f, %f)\n Accel: (%f, %f)\n"
60 " ScrollByPage: %d\n HasPreciseScrollingDeltas: %d\n" 60 " ScrollByPage: %d\n HasPreciseScrollingDeltas: %d\n"
61 " Phase: (%d, %d)\n CanRubberband: (%d, %d)\n}", 61 " Phase: (%d, %d)\n CanRubberband: (%d, %d)\n CanScroll: %d\n}",
62 event.deltaX, 62 event.deltaX,
63 event.deltaY, 63 event.deltaY,
64 event.wheelTicksX, 64 event.wheelTicksX,
65 event.wheelTicksY, 65 event.wheelTicksY,
66 event.accelerationRatioX, 66 event.accelerationRatioX,
67 event.accelerationRatioY, 67 event.accelerationRatioY,
68 event.scrollByPage, 68 event.scrollByPage,
69 event.hasPreciseScrollingDeltas, 69 event.hasPreciseScrollingDeltas,
70 event.phase, 70 event.phase,
71 event.momentumPhase, 71 event.momentumPhase,
72 event.canRubberbandLeft, 72 event.canRubberbandLeft,
73 event.canRubberbandRight); 73 event.canRubberbandRight,
74 event.canScroll);
74 } 75 }
75 76
76 void ApppendEventDetails(const WebGestureEvent& event, std::string* result) { 77 void ApppendEventDetails(const WebGestureEvent& event, std::string* result) {
77 StringAppendF(result, 78 StringAppendF(result,
78 "{\n Pos: (%d, %d)\n GlobalPos: (%d, %d)\n SourceDevice: %d\n" 79 "{\n Pos: (%d, %d)\n GlobalPos: (%d, %d)\n SourceDevice: %d\n"
79 " RawData: (%f, %f, %f, %f, %d)\n}", 80 " RawData: (%f, %f, %f, %f, %d)\n}",
80 event.x, 81 event.x,
81 event.y, 82 event.y,
82 event.globalX, 83 event.globalX,
83 event.globalY, 84 event.globalY,
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 event->movementY += y; 143 event->movementY += y;
143 } 144 }
144 145
145 bool CanCoalesce(const WebMouseWheelEvent& event_to_coalesce, 146 bool CanCoalesce(const WebMouseWheelEvent& event_to_coalesce,
146 const WebMouseWheelEvent& event) { 147 const WebMouseWheelEvent& event) {
147 return event.modifiers == event_to_coalesce.modifiers && 148 return event.modifiers == event_to_coalesce.modifiers &&
148 event.scrollByPage == event_to_coalesce.scrollByPage && 149 event.scrollByPage == event_to_coalesce.scrollByPage &&
149 event.phase == event_to_coalesce.phase && 150 event.phase == event_to_coalesce.phase &&
150 event.momentumPhase == event_to_coalesce.momentumPhase && 151 event.momentumPhase == event_to_coalesce.momentumPhase &&
151 event.hasPreciseScrollingDeltas == 152 event.hasPreciseScrollingDeltas ==
152 event_to_coalesce.hasPreciseScrollingDeltas; 153 event_to_coalesce.hasPreciseScrollingDeltas &&
154 event.canScroll == event_to_coalesce.canScroll;
153 } 155 }
154 156
155 float GetUnacceleratedDelta(float accelerated_delta, float acceleration_ratio) { 157 float GetUnacceleratedDelta(float accelerated_delta, float acceleration_ratio) {
156 return accelerated_delta * acceleration_ratio; 158 return accelerated_delta * acceleration_ratio;
157 } 159 }
158 160
159 float GetAccelerationRatio(float accelerated_delta, float unaccelerated_delta) { 161 float GetAccelerationRatio(float accelerated_delta, float unaccelerated_delta) {
160 if (unaccelerated_delta == 0.f || accelerated_delta == 0.f) 162 if (unaccelerated_delta == 0.f || accelerated_delta == 0.f)
161 return 1.f; 163 return 1.f;
162 return unaccelerated_delta / accelerated_delta; 164 return unaccelerated_delta / accelerated_delta;
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 case WebInputEvent::TouchStart: 481 case WebInputEvent::TouchStart:
480 case WebInputEvent::TouchMove: 482 case WebInputEvent::TouchMove:
481 case WebInputEvent::TouchEnd: 483 case WebInputEvent::TouchEnd:
482 return !static_cast<const WebTouchEvent&>(event).cancelable; 484 return !static_cast<const WebTouchEvent&>(event).cancelable;
483 default: 485 default:
484 return false; 486 return false;
485 } 487 }
486 } 488 }
487 489
488 } // namespace content 490 } // namespace content
OLDNEW
« no previous file with comments | « content/common/input/synthetic_web_input_event_builders.cc ('k') | content/common/input/web_input_event_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698