Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 739013004: Reland of "TransitionArray::Search() now returns insertion index if the entry was not found." (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland of "TransitionArray::Search() now returns insertion index if the entry was not found."

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -52 lines) Patch
M src/objects.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/objects-inl.h View 5 chunks +34 lines, -13 lines 0 comments Download
M src/transitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/transitions.cc View 4 chunks +32 lines, -30 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Igor Sheludko
PTAL (this is a clean reland without any additional changes)
6 years ago (2014-11-24 12:40:55 UTC) #2
Toon Verwaest
(rubberstamp) lgtm
6 years ago (2014-11-24 13:09:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739013004/1
6 years ago (2014-11-24 14:04:05 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 14:31:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698