Re-land chromeos: Add non-extension renderers to the freezer cgroup

Re-land chromeos: Add non-extension renderers to the freezer cgroup

In preparation for lucid sleep, we will be putting all chrome renderers
that do not host GCM extensions into a special freezer cgroup.  All
processes in this cgroup will be frozen when the system suspends and
will not be thawed until the system has fully resumed.

The code to freeze and thaw the cgroup has existed for a while.  This
code actually starts putting processes into the cgroup.

Additionally, to deal with potential races that may occur with other
suspend observers that interact with renderers, the RendererFreezer is
no longer a PowerManagerClient::Observer but is instead a
PowerManagerClient::RenderProcessManagerDelegate.  This guarantees that
the RendererFreezer's suspend related methods will be called only after
all observers have reported ready and before observers are notified that
the suspend has completed.  Any race conditions that still exist now
need to be fixed in the observer that is causing it.

BUG=364339
Committed: https://crrev.com/1a085efa9263279b58d6fd06ba991709d598f796
Cr-Commit-Position: refs/heads/master@{#304956}

[Chirantan Ekbote, 2014-11-19 23:35:09]

chirantan@chromium.org changed reviewers:
+ derat@chromium.org

[Chirantan Ekbote, 2014-11-19 23:35:10]

Please take a look.

[Daniel Erat, 2014-11-19 23:41:26]

lgtm

thanks for uploading the old version first!

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.cc:754:
base::WeakPtr<RenderProcessManagerDelegate> delegate_;
nit: maybe rename to render_process_manager_delegate_ or renderer_delegate_ or
something more specific

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.h (right):

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.h:112: // observers have reported readiness
to suspend.
mind also documenting how this interacts with dark resume?

[Chirantan Ekbote, 2014-11-20 00:59:37]

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.cc:754:
base::WeakPtr<RenderProcessManagerDelegate> delegate_;
On 2014/11/19 23:41:26, Daniel Erat wrote:
> nit: maybe rename to render_process_manager_delegate_ or renderer_delegate_ or
> something more specific

Done.

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.h (right):

https://codereview.chromium.org/738993002/diff/20001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.h:112: // observers have reported readiness
to suspend.
On 2014/11/19 23:41:26, Daniel Erat wrote:
> mind also documenting how this interacts with dark resume?

Done.

[Chirantan Ekbote, 2014-11-20 00:59:41]

The CQ bit was checked by chirantan@chromium.org

[commit-bot: I haz the power, 2014-11-20 01:01:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738993002/40001

[commit-bot: I haz the power, 2014-11-20 01:44:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-20 01:45:49]

Patchset 3 (id:??) landed as
https://crrev.com/1a085efa9263279b58d6fd06ba991709d598f796
Cr-Commit-Position: refs/heads/master@{#304956}

[spang, 2014-12-01 22:19:08]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/753313005/ by spang@chromium.org.

The reason for reverting is: Crashes (especially on login)

BUG=364339, 437962.