Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 738983002: Move output surface fallback from cc to embedders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index 02fedcd19db9dad86eaa850560c716bbb86852fb..2343d4ea2ec323fe3d278d391b2e07ed96d51f59 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -524,7 +524,7 @@ void CompositorImpl::Layout() {
ignore_schedule_composite_ = false;
}
-void CompositorImpl::RequestNewOutputSurface(bool fallback) {
+void CompositorImpl::RequestNewOutputSurface() {
BrowserGpuChannelHostFactory* factory =
BrowserGpuChannelHostFactory::instance();
if (!factory->GetGpuChannel() || factory->GetGpuChannel()->IsLost()) {
@@ -533,15 +533,18 @@ void CompositorImpl::RequestNewOutputSurface(bool fallback) {
factory->EstablishGpuChannel(
cause,
base::Bind(&CompositorImpl::CreateOutputSurface,
- weak_factory_.GetWeakPtr(),
- fallback));
+ weak_factory_.GetWeakPtr()));
return;
}
- CreateOutputSurface(fallback);
+ CreateOutputSurface();
}
-void CompositorImpl::CreateOutputSurface(bool fallback) {
+void CompositorImpl::DidFailToInitializeOutputSurface() {
+ RequestNewOutputSurface();
+}
+
+void CompositorImpl::CreateOutputSurface() {
blink::WebGraphicsContext3D::Attributes attrs;
attrs.shareResources = true;
attrs.noAutomaticFlushes = true;

Powered by Google App Engine
This is Rietveld 408576698