Makes ImageView do a bit more checking before assuming images equal

Makes ImageView do a bit more checking before assuming images equal

This covers the case of the storage not changing, but the bits in the
storage changing, as happens with extensions.

BUG=319251
TEST=see bug.
R=pkotwicz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235691

[pkotwicz, 2013-11-15 20:57:08]

LGTM

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
File ui/views/controls/image_view.cc (right):

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
ui/views/controls/image_view.cc:29: if (IsImageEqual(img))
Can you please add a comment (in the code) as to why IsImageEqual() works the
way it does. (Which bug / suboptimality IsImageEqual() is working around)

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
File ui/views/controls/image_view.h (right):

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
ui/views/controls/image_view.h:89: // this may return false even though the
images are in fact equal.
Nit: "this may return false" -> "that this returns false"

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
ui/views/controls/image_view.h:122: void* last_painted_image_;
Maybe |last_painted_bitmap_| I try to reserve the "image" keyword for gfx::Image
and gfx::ImageSkia

[sky, 2013-11-15 22:19:13]

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
File ui/views/controls/image_view.cc (right):

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
ui/views/controls/image_view.cc:29: if (IsImageEqual(img))
On 2013/11/15 20:57:09, pkotwicz wrote:
> Can you please add a comment (in the code) as to why IsImageEqual() works the
> way it does. (Which bug / suboptimality IsImageEqual() is working around)

I placed the comment in IsImageEqual.

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
File ui/views/controls/image_view.h (right):

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
ui/views/controls/image_view.h:89: // this may return false even though the
images are in fact equal.
On 2013/11/15 20:57:09, pkotwicz wrote:
> Nit: "this may return false" -> "that this returns false"

Done.

https://codereview.chromium.org/73893007/diff/30001/ui/views/controls/image_v...
ui/views/controls/image_view.h:122: void* last_painted_image_;
On 2013/11/15 20:57:09, pkotwicz wrote:
> Maybe |last_painted_bitmap_| I try to reserve the "image" keyword for
gfx::Image
> and gfx::ImageSkia

I went with last_painted_bitmap_pixels_

[commit-bot: I haz the power, 2013-11-15 23:00:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/73893007/90001

[commit-bot: I haz the power, 2013-11-16 01:30:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/73893007/90001

[commit-bot: I haz the power, 2013-11-18 11:04:02]

Change committed as 235691