Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738863002: Move TextPainter to core/paint/ (Closed)

Created:
6 years, 1 month ago by fs
Modified:
6 years, 1 month ago
Reviewers:
pdr., slimming-paint-reviews
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org
Project:
blink
Visibility:
Public.

Description

Move TextPainter to core/paint/ Also clean out a bunch of unused includes from core/rendering/InlineTextBox.cpp. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -461 lines) Patch
M Source/core/core.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/paint/EllipsisBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/paint/TextPainter.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/paint/TextPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/paint/TextPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
D Source/core/rendering/TextPainter.h View 1 chunk +0 lines, -90 lines 0 comments Download
D Source/core/rendering/TextPainter.cpp View 1 chunk +0 lines, -218 lines 0 comments Download
D Source/core/rendering/TextPainterTest.cpp View 1 chunk +0 lines, -129 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
6 years, 1 month ago (2014-11-18 14:34:37 UTC) #2
pdr.
On 2014/11/18 at 14:34:37, fs wrote: > LGTM
6 years, 1 month ago (2014-11-18 16:15:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738863002/1
6 years, 1 month ago (2014-11-18 16:49:15 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 16:51:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185534

Powered by Google App Engine
This is Rietveld 408576698