Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros.

Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros. Also, fixed permissions checks for channel switcher UI in a multi-profiles sessions.

BUG=433840
TEST=existing unit_tests for OwnerSettingsService

Committed: https://crrev.com/e0ed5a18bc9e3fa930f1af3b8f9c3cfdb91329f5
Cr-Commit-Position: refs/heads/master@{#305012}

[ygorshenin1, 2014-11-19 14:58:19]

ygorshenin@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Nikita (slow), 2014-11-19 17:45:59]

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h
(right):

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h:33:
static OwnerSettingsServiceChromeOS* GetForProfile(Profile* profile);
I suggest dropping this method and always use GetForBrowserContext()

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/help/help_handler.cc:288:
version_updater_.reset(VersionUpdater::Create(Profile::FromWebUI(web_ui())));
VersionUpdater::Create(web_ui()->GetWebContents()->GetBrowserContext())

[Nikita (slow), 2014-11-19 17:46:07]

lgtm

[ygorshenin1, 2014-11-19 18:30:44]

Many thanks!

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h
(right):

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h:33:
static OwnerSettingsServiceChromeOS* GetForProfile(Profile* profile);
On 2014/11/19 17:45:59, Nikita wrote:
> I suggest dropping this method and always use GetForBrowserContext()

Done.

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/help/help_handler.cc (right):

https://codereview.chromium.org/738843002/diff/60001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/help/help_handler.cc:288:
version_updater_.reset(VersionUpdater::Create(Profile::FromWebUI(web_ui())));
On 2014/11/19 17:45:59, Nikita wrote:
> VersionUpdater::Create(web_ui()->GetWebContents()->GetBrowserContext())

Done.

[ygorshenin1, 2014-11-19 18:30:48]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-11-19 18:31:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738843002/80001

[commit-bot: I haz the power, 2014-11-19 18:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-19 18:57:07]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/83604)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ygorshenin1, 2014-11-20 12:42:58]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-11-20 12:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738843002/100001

[commit-bot: I haz the power, 2014-11-20 13:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 13:17:34]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/84101)

[ygorshenin1, 2014-11-20 13:25:02]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-11-20 13:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/738843002/120001

[commit-bot: I haz the power, 2014-11-20 14:39:54]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-11-20 14:41:24]

Patchset 7 (id:??) landed as
https://crrev.com/e0ed5a18bc9e3fa930f1af3b8f9c3cfdb91329f5
Cr-Commit-Position: refs/heads/master@{#305012}

[earthdok, 2014-12-10 15:54:14]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/790183002/ by earthdok@chromium.org.

The reason for reverting is: Speculative revert to see if this is the cause of
issue 440063.

BUG=440063
TBR=ygorshenin@chromium.org.