Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738833002: Un-deprecate APIs which have been un-removed in the DOM Standard (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Un-deprecate APIs which have been un-removed in the DOM Standard https://dom.spec.whatwg.org/#dom-attr-ownerelement https://dom.spec.whatwg.org/#dom-document-createattributens Element.setAttributeNodeNS() is also back in the spec, but is under discussion: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27344 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185531

Patch Set 1 #

Patch Set 2 : exclude Element.setAttributeNodeNS() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M LayoutTests/dom/xhtml/level3/core/documentadoptnode01-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode02-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode03-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode04-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode05-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode21-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-18 13:36:24 UTC) #2
Mike West
LGTM, assuming that the DOM standard is unlikely to un-un-remove the APIs. It would be ...
6 years, 1 month ago (2014-11-18 13:39:51 UTC) #3
philipj_slow
Document.createAttributeNS and Attr.ownerElement were failed removals, so those probably won't go away again soon. Element.setAttributeNodeNS() ...
6 years, 1 month ago (2014-11-18 13:47:48 UTC) #4
Mike West
On 2014/11/18 13:47:48, philipj wrote: > If you like I can exclude it from this ...
6 years, 1 month ago (2014-11-18 13:52:58 UTC) #5
philipj_slow
exclude Element.setAttributeNodeNS()
6 years, 1 month ago (2014-11-18 14:13:49 UTC) #6
philipj_slow
I'll send a PSA after landing.
6 years, 1 month ago (2014-11-18 14:14:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738833002/20001
6 years, 1 month ago (2014-11-18 14:15:41 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 16:16:50 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185531

Powered by Google App Engine
This is Rietveld 408576698