Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 738773003: Revert of Oilpan: Refactor the way we calculate heap statistics (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, kouhei+heap_chromium.org, Mikhail
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Refactor the way we calculate heap statistics (patchset #12 id:220001 of https://codereview.chromium.org/723513002/) Reason for revert: [Sheriff] Breaks compilation on win x64: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/25605 Original issue's description: > Oilpan: Refactor the way we calculate heap statistics > > This is a preparation for implementing incremental sweeping. > > - Remove ThreadState::HeapStats. > > - Introduce Heap::allocatedSpace, Heap::allocatedObjectSize and Heap::liveObjectSize. > > --- Heap::allocatedSpace keeps track of the size of allocated space. > > --- Heap::allocatedObjectSize keeps track of the size of objects allocated since the last GC. > > --- Heap::liveObjectSize keeps track of the size of marked objects in the last GC. > > - Adds a couple of atomic instructions to Atomics.h to update the Heap metrics atomically. > > - This CL fixes the issue that shouldGC() determines GC timing only based on the size of the current thread heap. After this CL, shouldGC() determines GC timing based on the entire heap. > > - Rename getStatsForTesting() to objectPayloadSizeForTesting(). > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185513 TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,tkent@chromium.org,vegorov@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -255 lines) Patch
M Source/platform/heap/Heap.h View 13 chunks +12 lines, -26 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 23 chunks +57 lines, -57 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 40 chunks +134 lines, -93 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 6 chunks +71 lines, -7 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 13 chunks +75 lines, -48 lines 0 comments Download
M Source/wtf/Atomics.h View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Oilpan: Refactor the way we calculate heap statistics
6 years, 1 month ago (2014-11-18 11:48:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738773003/1
6 years, 1 month ago (2014-11-18 11:49:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=185514
6 years, 1 month ago (2014-11-18 11:49:45 UTC) #3
haraken
6 years, 1 month ago (2014-11-18 11:51:18 UTC) #4
Message was sent while issue was closed.
LGTM, thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698