Issue 738763002: ServiceWorker: Remove outdated 'id' attribute from ServiceWorkerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 738763002: ServiceWorker: Remove outdated 'id' attribute from ServiceWorkerClient (Closed)

Created:
6 years, 1 month ago by nhiroki

Modified:
6 years, 1 month ago

Reviewers:
horo

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Remove outdated 'id' attribute from ServiceWorkerClient This attribute is gone from the spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-client BUG=434253 TEST=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185565

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	Source/modules/serviceworkers/ServiceWorkerClient.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/modules/serviceworkers/ServiceWorkerClient.idl	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738763002/1

6 years, 1 month ago (2014-11-19 01:41:49 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-19 03:01:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185565

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages