Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738733006: DevTools: Support harmony variable scopes. (Closed)

Created:
6 years, 1 month ago by aandrey
Modified:
6 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Support harmony variable scopes. This adds support of "Block" and "Script" variable scopes to DevTools. BUG=433324 R=yurys, dslomov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185801

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -72 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html View 1 1 chunk +79 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes-expected.txt View 1 1 chunk +36 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-expand-scope.html View 1 chunk +22 lines, -38 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-expand-scope-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/DebuggerScript.js View 2 chunks +7 lines, -4 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 2 chunks +16 lines, -15 lines 0 comments Download
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aandrey
6 years, 1 month ago (2014-11-21 12:01:45 UTC) #1
yurys
lgtm https://codereview.chromium.org/738733006/diff/1/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html File LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html (right): https://codereview.chromium.org/738733006/diff/1/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html#newcode16 LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html:16: let makeClosureDeeperBlockVar = "block.deep." + n; I'd also ...
6 years, 1 month ago (2014-11-21 13:30:54 UTC) #2
aandrey
https://codereview.chromium.org/738733006/diff/1/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html File LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html (right): https://codereview.chromium.org/738733006/diff/1/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html#newcode16 LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html:16: let makeClosureDeeperBlockVar = "block.deep." + n; On 2014/11/21 13:30:54, ...
6 years, 1 month ago (2014-11-21 13:53:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738733006/20001
6 years, 1 month ago (2014-11-21 13:54:19 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 15:17:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185801

Powered by Google App Engine
This is Rietveld 408576698