Opening new "about:blank" tab if all tabs are closed in tab switcher mode.

chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java
index 58ae32709ce425e9e76c9f3f41d4c0390e2ecc03..cb03412cc243312f859f94e5cf4ba795a82a50db 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java
@@ -453,6 +453,7 @@ public abstract class TabModelBase extends TabModelJniBridge {
         }
 
         mTabs.remove(tab);
+        for (TabModelObserver obs : mObservers) obs.didCloseTab(tab);

[Bernhard Bauer, 2014/11/19 09:57:34]

Why this change? didCloseTab() means that closing the tab is done, but here we
are just starting to close the tab (it's not instantaneous because there's
animations etc.)

[divya.bansal, 2014/11/19 10:04:24]

Here after tab is removed didclosetab is called.If didclosetab() in
finalizetabclosure is used, that is not instantaneous and there after tab is
removed focus goes to url bar and then after some time new tab opens.
But here its happening instantaneously.

[Bernhard Bauer, 2014/11/19 10:06:45]

Right, but you can't just go ahead and change the semantics of existing
notifications. That is almost guaranteed to break things.

Does using willCloseTab not work?

[divya.bansal, 2014/11/19 10:09:39]

willCloseTab() is set even before tab is removed in starttabclosure(), so there
still count !=0 and if in that i open a new tab, after that tab is removed.

[Bernhard Bauer, 2014/11/19 10:13:53]

Would it work if you call createNewTab() if the count is 1?

[divya.bansal, 2014/11/19 12:07:57]

Done.

 
         boolean nextIsIncognito = nextTab == null ? false : nextTab.isIncognito();
         int nextTabId = nextTab == null ? Tab.INVALID_TAB_ID : nextTab.getId();
@@ -477,7 +478,6 @@ public abstract class TabModelBase extends TabModelJniBridge {
      * @param tab The {@link Tab} to close.
      */
     private void finalizeTabClosure(Tab tab) {
-        for (TabModelObserver obs : mObservers) obs.didCloseTab(tab);
         tab.destroy();
     }