chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java - Issue 738693002: Opening new "about:blank" tab if all tabs are closed in tab switcher mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

Issue 738693002: Opening new "about:blank" tab if all tabs are closed in tab switcher mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

index c7e11d39773d075376369910872f0777255586b0..c6c0b9723968cdd76decd56ea9d9dfbd73900d72 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

@@ -18,7 +18,7 @@ import android.widget.EditText;

import android.widget.ListPopupWindow;

import android.widget.PopupWindow.OnDismissListener;

+import org.chromium.chrome.browser.UrlUtilities;

import org.chromium.chrome.browser.omnibox.AutocompleteController;

import org.chromium.chrome.browser.omnibox.AutocompleteController.OnSuggestionsReceivedListener;

import org.chromium.chrome.browser.omnibox.OmniboxSuggestion;

@@ -68,8 +68,8 @@ public class SuggestionPopup implements OnSuggestionsReceivedListener, TextWatch

}

private void navigateToSuggestion(int position) {

- mToolbar.getCurrentTab().loadUrlWithSanitization(

- mSuggestionArrayAdapter.getItem(position).getUrl());

+ mToolbar.getTabManager().openUrl(UrlUtilities.fixupUrl(

+ mSuggestionArrayAdapter.getItem(position).getUrl()));

mUrlField.clearFocus();

mToolbar.setKeyboardVisibilityForUrl(false);

mToolbar.getCurrentTab().getView().requestFocus();