Opening new "about:blank" tab if all tabs are closed in tab switcher mode.

chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.shell;
 
 import android.content.Context;
 import android.util.AttributeSet;
 import android.view.LayoutInflater;
 import android.view.View;
@@ skipping 37 matching lines @@
     private final EmptyTabModelObserver mTabModelObserver = new EmptyTabModelObserver() {
         @Override
         public void didSelectTab(Tab tab, TabSelectionType type, int lastId) {
             assert tab instanceof ChromeShellTab;
             setCurrentTab((ChromeShellTab) tab);
             hideTabSwitcher();
         }
 
         @Override
         public void willCloseTab(Tab tab, boolean animate) {
-            if (tab == mCurrentTab) setCurrentTab(null);
+            if (tab == mCurrentTab) {
+                hideTabSwitcher();
+                setCurrentTab(mCurrentTab);

[Bernhard Bauer, 2014/11/18 09:05:48]

Wait, why are we doing this?

[divya.bansal, 2014/11/18 09:20:19]

To get last tab so that its profile and url info we can use to create suggestion
popup.Otherwise in SuggestionPopUp.java, in afterTextChanged() function, if
mToolbar.getCurrentTab() == null, we return.

[Bernhard Bauer, 2014/11/18 09:27:58]

But this is called right before we close the tab. The caller assumes that the
tab doesn't exist anymore, and it's removed from the model. We can't just keep
the tab around.

We could do something like opening a new tab with about:blank if the last tab
(not necessarily the current one!) is closed.

[divya.bansal, 2014/11/19 09:51:30]

Done.

+            }
         }
     };
 
     /**
      * @param context The Context the view is running in.
      * @param attrs   The attributes of the XML tag that is inflating the view.
      */
     public TabManager(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
@@ skipping 176 matching lines @@
         LoadUrlParams loadUrlParams = new LoadUrlParams(url);
         loadUrlParams.setTransitionType(PageTransition.TYPED | PageTransition.FROM_ADDRESS_BAR);
         Tab tab = mTabModelSelector.getCurrentTab();
         if (tab != null) {
             tab.loadUrl(loadUrlParams);
             return tab;
         }
         return createTab(url, TabLaunchType.FROM_KEYBOARD);
     }
 }