Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 738683002: Move chromeos/tpm_* to chromeos/tpm (Closed)

Created:
6 years, 1 month ago by satorux1
Modified:
6 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move chromeos/tpm_* to chromeos/tpm These files are moved in favor of less files to have in the top-level chromeos directory. BUG=none TEST=builds as before Committed: https://crrev.com/612142321c115cc876e1d5306c22b35f1859ab74 Cr-Commit-Position: refs/heads/master@{#308020}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fix the build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1331 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/tpm/tpm_password_fetcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chromeos/tpm/tpm_password_fetcher.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/tpm/tpm_token_info_getter.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chromeos/tpm/tpm_token_info_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/tpm/tpm_token_info_getter_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + chromeos/tpm/tpm_token_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chromeos/tpm/tpm_token_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chromeos/tpm_password_fetcher.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chromeos/tpm_password_fetcher.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chromeos/tpm_token_info_getter.h View 1 1 chunk +0 lines, -127 lines 0 comments Download
D chromeos/tpm_token_info_getter.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D chromeos/tpm_token_info_getter_unittest.cc View 1 chunk +0 lines, -525 lines 0 comments Download
D chromeos/tpm_token_loader.h View 1 chunk +0 lines, -131 lines 0 comments Download
D chromeos/tpm_token_loader.cc View 1 chunk +0 lines, -231 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
satorux1
6 years, 1 month ago (2014-11-18 06:19:53 UTC) #2
tbarzic
On 2014/11/18 06:19:53, satorux1 wrote: lgtm, but can you wait with this for about a ...
6 years, 1 month ago (2014-11-18 19:15:55 UTC) #3
satorux1
sure. there is no rush. please ping me once it's ready.
6 years, 1 month ago (2014-11-18 20:08:37 UTC) #4
satorux1
ping. is it ready now?
6 years ago (2014-12-08 02:26:54 UTC) #5
tbarzic
On 2014/12/08 02:26:54, satorux1 wrote: > ping. is it ready now? it should be ok ...
6 years ago (2014-12-08 05:13:37 UTC) #6
satorux1
+thestig@ for files out side of chromeos or chrome/browser/chromeos: chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h chrome/browser/profiles/profile_io_data.cc
6 years ago (2014-12-08 05:30:17 UTC) #8
Lei Zhang
lgtm
6 years ago (2014-12-08 20:08:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738683002/20001
6 years ago (2014-12-08 20:11:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28907)
6 years ago (2014-12-08 20:18:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738683002/60001
6 years ago (2014-12-09 05:26:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29035)
6 years ago (2014-12-09 05:32:35 UTC) #17
satorux1
+stevenjb for chromeos/network. PTAL
6 years ago (2014-12-09 07:51:17 UTC) #19
satorux1
stevenjb@: ping for chromeos/network +pneubeck@ in case stevenjb@ is out of town
6 years ago (2014-12-11 06:52:46 UTC) #21
stevenjb
lgtm
6 years ago (2014-12-11 17:47:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738683002/60001
6 years ago (2014-12-12 01:27:57 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-12 01:32:50 UTC) #25
commit-bot: I haz the power
6 years ago (2014-12-12 01:34:15 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/612142321c115cc876e1d5306c22b35f1859ab74
Cr-Commit-Position: refs/heads/master@{#308020}

Powered by Google App Engine
This is Rietveld 408576698