Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738613003: Enables speech APIs to input method extensions. (Closed)

Created:
6 years, 1 month ago by Shu Chen
Modified:
6 years, 1 month ago
Reviewers:
James Hawkins
CC:
chromium-reviews, nkostylev+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enables speech APIs to input method extensions. BUG=434231 TEST=Verified on clapper device. Committed: https://crrev.com/e551e93dedc47262fa9e4ca819f5bd3647cf7894 Cr-Commit-Position: refs/heads/master@{#304951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/media/media_capture_devices_dispatcher.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Shu Chen
jhawkins@, can you please review this cl? Thanks
6 years, 1 month ago (2014-11-18 03:57:56 UTC) #2
James Hawkins
lgtm
6 years, 1 month ago (2014-11-19 17:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738613003/1
6 years, 1 month ago (2014-11-20 00:29:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 01:13:54 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 01:15:38 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e551e93dedc47262fa9e4ca819f5bd3647cf7894
Cr-Commit-Position: refs/heads/master@{#304951}

Powered by Google App Engine
This is Rietveld 408576698